Conversation
Collaborator
Author
There was a problem hiding this comment.
the form component uses getter/setters to access properties, jms serializer uses reflection by default. The line was an attempt to synchronize behavior, however jms serailizer doesnt detect public properties and therefore fails when using "public_method" with my test objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialization performance of larger graphs with the form component is very slow. This is due to the form creating and binding of data. Compared to that JMS Serializer bundle is very fast.
We should aim at using JMS Serializer for serialization, based on Form Type Metadata. The same form type metadata is used for deserialization.
How it works:
You create a form type, then hint for a class which type it is:
This is a WIP, what needs to be done: